Issue 9577 - Text can be typed whilst the package manager syncs with the server. #9583
Conversation
Added styles to control package search information text.
…d. Both text boxes now have transparent backgrounds, caret brush set to white (otherwise it's black).
src/DynamoCoreWpf/Views/PackageManager/PackageManagerSearchView.xaml
Outdated
Show resolved
Hide resolved
|
Thanks for this work @RyaPorter - this seems like functionality that should have a test which verifies the correct properties for the text box given a modified state. |
…o control component behaviour. Added old visibility converter to collpse search box prompt when text is being typed.
|
Thanks @mjkkirschner . I've made some changes as suggested. Instead of using styles, the behaviour of the two text boxes is now controlled by properties in the view model and appropriate tests have been added to test these properties. |
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Show resolved
Hide resolved
| @@ -156,6 +183,8 @@ public PackageSearchState SearchState | |||
| { | |||
| _searchState = value; | |||
| RaisePropertyChanged("SearchState"); | |||
| RaisePropertyChanged("SearchBoxPrompt"); | |||
There was a problem hiding this comment.
you should be able to use nameof here
|
Thanks for pushing this forward, and adding the tests, just a few more requests. |
|
Cheers, I've made the changes now. |
| @@ -145,17 +181,21 @@ public bool HasNoResults | |||
| get { return this.SearchResults.Count == 0; } | |||
| } | |||
|
|
|||
|
|
|||
| public PackageSearchState _searchState; | |||
There was a problem hiding this comment.
@RyaPorter Can you add a comment suggesting that this backing field be set to private in Dynamo 3.0? Doing so now would unfortunately introduce an API breaking change.
|
Hey @RyaPorter, I add one comment suggesting we add a comment for future reference regarding a public/private assessor. Otherwise, I pulled down this branch for some local testing and everything seems to be working as expected. I also ran the branch on the self-serve CI verifying all new/existing tests successfully pass. @mjkkirschner @QilongTang I believe this should be good to go otherwise. |
|
@alfarok I've added that comment. Also added comments to some other public backing fields I spotted. |
|
Thanks @RyaPorter, LGTM merging 👍 |
…the server. (#9583) * Added "Please wait..." string to resource files. Added styles to control package search information text. * Applied styles to text boxes. * Swapped grey background colour from search text box to search box grid. Both text boxes now have transparent backgrounds, caret brush set to white (otherwise it's black). * Removed styles and add testable properties in the viewmodel instead to control component behaviour. Added old visibility converter to collpse search box prompt when text is being typed. * Renamed string resource for "Please Wait..." to be a little bit more generic. * Added unit tests to test search box behaviour based on different search states. * Added property summaries. Replaced property name strings with nameof * Added comments on non-private backing fields.
Purpose
Fixes Issue 9577. The search text box is now collapsed until the package manager has finished syncing with the server. After this the search box functions as before.
Declarations
Check these if you believe they are true
*.resxfiles