Rc2.0.3 lib crash #9568
Merged
Rc2.0.3 lib crash #9568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
commented
Mar 13, 2019
| @@ -74,9 +74,9 @@ protected Stream GetNodeItemDataStream(IEnumerable<NodeSearchElement> searchEntr | |||
| protected virtual object CreateObjectForSerialization(IEnumerable<NodeSearchElement> searchEntries) | |||
| { | |||
| var data = new LoadedTypeData<LoadedTypeItem>(); | |||
| data.loadedTypes = searchEntries | |||
| //.Where(e => !e.ElementType.HasFlag(ElementTypes.Packaged)) | |||
There was a problem hiding this comment.
@aparajit-pratap @reddyashish @ColinDayOrg - it just occurs to me that this commented out code is kind of peculiar, does anyone know why this was left in?
There was a problem hiding this comment.
Sorry was waiting for others to see if they knew about this. I am not sure why that line was commented in the first place. I assumed we are not using that attribute filter anymore.
The changes look good.
horatiubota
added
the
error/warning/crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reddyashish does this look correct?