Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick: Render precision save (#9108) #9562

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

scottmitchell
Copy link
Collaborator

  • ALS-5190 Dynamo: Render Precision setting is not remembered

  • Set correct path to ProtoGeometry lib

  • Return comment removed by accident

  • Add missing line

  • Add new interface

  • Copy Background Preview test

  • Creating RenderPrecision test

  • Updated RenderPrecision test

  • Removed inheritance I was testing

  • Added RenderPackageFactoryViewModel constructor

  • Updated constructor

  • Add TODO

  • Add test that loads settings file that does not contain RenderPrecision

  • Added const fro DefaultRenderPrecision

  • Added jira task

Purpose

2.2.0 Cherry pick of #9108

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

* ALS-5190 Dynamo: Render Precision setting is not remembered

* Set correct path to ProtoGeometry lib

* Return comment removed by accident

* Add missing line

* Add new interface

* Copy Background Preview test

* Creating RenderPrecision test

* Updated RenderPrecision test

* Removed inheritance I was testing

* Added RenderPackageFactoryViewModel constructor

* Updated constructor

* Add TODO

* Add test that loads settings file that does not contain RenderPrecision

* Added const fro DefaultRenderPrecision

* Added jira task
@mjkkirschner
Copy link
Member

LGTM

@mjkkirschner mjkkirschner added the LGTM Looks good to me label Mar 11, 2019
@scottmitchell scottmitchell merged commit 9a77032 into DynamoDS:RC2.2.0_master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants