Optimize live execution of modified graphs #9485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
# Conflicts: # src/Engine/ProtoScript/Runners/LiveRunner.cs
Run second exection via ApplyUpdate similar to previous run model
aparajit-pratap
added a commit
that referenced
this pull request
Apr 26, 2022
This reverts commit dac8353.
aparajit-pratap
added a commit
that referenced
this pull request
Apr 26, 2022
8 tasks
|
Merged by mistake, reverted in #12834 |
aparajit-pratap
added a commit
that referenced
this pull request
May 19, 2022
* optimization of execution of modified graphs * fix live execution tests for modified inputs * code cleanup * code fix * code fixes * mark added subtrees as input subtrees * Fix incorrect merge conflict flix * Changes to fix build * Run second exection via ApplyUpdate similar to previous run model * add support for string input * Ignore unsupported inputs (dropdown, datetime, etc) * update for case with modified UI node * support multiple modified inputs * reset stackframe pointer after removing LX register * cleanup * cleanup * revert breaking change of converting from struct to class * cleanup update register for deleted ASTs * make subtree a class again at the risk of breaking API for users * keep Subtree a public struct * optimize Co-authored-by: Craig Long <[email protected]> Co-authored-by: Craig Long <[email protected]>
QilongTang
changed the title
QilongTang
added
DNM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This implementation tries to optimize live execution of modified graphs as per the following design:
https://docs.google.com/document/d/1k7bJ8jO9QeBz5YjY5MbfFB7v7b1NJJwav7if1nfes_Y/edit
Re-execution of modified graphs is optimized only for the case of modified inputs where the inputs are primitive values only. As a future optimization we can include cases (2) a statement is redefined and (3) a function is redefined.
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@saintentropy