Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OpenIfSaved API for DynamoPlayer #9443

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Jan 19, 2019

Purpose

update the filePath property of the DynamoView as deserializing the view block of json files relies on it being correct.

@Racel Not sure what you want to do with this change regarding 2.1 x 2.2.
In terms of risk, it's small because this API is not called by many clients, I think only Player calls this, perhaps some extensions as well.

While this does not cause a crash, it does cause graphs to fail to open via player edit button without first closing dynamo.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@QilongTang

FYIs

@Racel @smangarole

…he model command so the view loads the right filePath...
@QilongTang
Copy link
Contributor

QilongTang commented Jan 19, 2019

@mjkkirschner Can you update the unit tests introduced in #7061?

For example, in the unit test EnsureSaveDialogIsShownOnOpenIfSaveCommand add

ViewModel.OpenIfSavedCommand.Execute(new Dynamo.Models.DynamoModel.OpenFileCommand(openPath));
//assert the path updated 
Assert.AreEqual(ViewModel.FilePath ,openPath);

Other than that, LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Jan 20, 2019
@QilongTang
Copy link
Contributor

LGTM

@mjkkirschner mjkkirschner merged commit 369e7dc into DynamoDS:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants