Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli import arg #9366

Merged
merged 5 commits into from
Jan 4, 2019
Merged

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Jan 3, 2019

Purpose

Adds another flag to the CLI and WPFCLI - import -i /i - The import flag can be used multiple times when using the -open flag and will instruct dynamo to import an assembly as a node library before running the file referenced by the open command.

an example is:
/o {a_file} /i {dll1.dll} /i {dll2.dll} ;

a few simple tests are added.

This functionality is not added for DynamoSandbox.

This change needs to be documented in the CLI docs.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@ColinDayOrg
@scottmitchell

FYIs

@smangarole @jhauswirth @sm6srw

add functionality to WPF CLI
fix cli command parser for tests
@mjkkirschner mjkkirschner changed the title Cli import option Cli import arg Jan 3, 2019
@mjkkirschner mjkkirschner added the PTAL Please Take A Look 👀 label Jan 3, 2019
@ColinDayOrg
Copy link
Contributor

LGTM.
In the tests it is not immediately clear what the AssertPreviewValue tests are checking for, possibly a comment would help, but not necessarily needed.

@scottmitchell
Copy link
Collaborator

LGTM!

@mjkkirschner mjkkirschner added LGTM Looks good to me and removed PTAL Please Take A Look 👀 labels Jan 4, 2019
@mjkkirschner mjkkirschner merged commit 92979dc into DynamoDS:master Jan 4, 2019
QilongTang added a commit that referenced this pull request Jan 7, 2019
QilongTang added a commit that referenced this pull request Jan 7, 2019
* Revert "Cli import arg (#9366)"

This reverts commit 92979dc.

* Revert "LibG Binaries Update (#9371)"

This reverts commit 3591642.

* Revert "Remove Legacy LibG Versions (#9358)"

This reverts commit 0622384.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants