Heterogeneous list update gives infinite loop #9334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @reddyashish, LGTM! |
|
LGTM |
reddyashish
added a commit
that referenced
this pull request
Jan 2, 2019
This reverts commit 67a19a7.
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
Jan 2, 2019
This reverts commit 67a19a7.
QilongTang
pushed a commit
that referenced
this pull request
Jan 2, 2019
mjkkirschner
added a commit
that referenced
this pull request
Jan 3, 2019
mjkkirschner
added a commit
that referenced
this pull request
Jan 3, 2019
QilongTang
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Revert "Heterogeneous list update gives infinite loop (#9334)" This reverts commit 67a19a7. * Obsoleting Surface.Join Node. (#9399) * Add check for invalid cutom node name https://jira.autodesk.com/browse/QNTM-3928 * Removing trailing spaces * Moving the function to utilities class * Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo" This reverts commit 085fb51, reversing changes made to d055de4. * Revert "Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo"" This reverts commit 12538ab. * Adding tests - QNTM-3928 * Comments * Moving the test to NodeViewCustomizationTests.cs * Deleting changes to SerializationTests.cs * Create SerializationTests.cs * Update SerializationTests.cs * moving the test to UtilityTests.ca * Heterogeneous list update gives infinite loop DYN-1198 * Moving the test dyn file * Revert "Moving the test dyn file" This reverts commit d91009e. * Revert "Heterogeneous list update gives infinite loop" This reverts commit e8d7b8a. * making Surface.join node obsolete * Revert "making Surface.join node obsolete" This reverts commit 1458b46. * Obsoleting Surface,Join node. Use Polysurface.ByJoinedSurfaces node instead. * Renaming test file. (cherry picked from commit dee10b6) * Updating the file name related to DYN-1043 (Obsoleting surface.join node) (#9410) * Add check for invalid cutom node name https://jira.autodesk.com/browse/QNTM-3928 * Removing trailing spaces * Moving the function to utilities class * Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo" This reverts commit 085fb51, reversing changes made to d055de4. * Revert "Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo"" This reverts commit 12538ab. * Adding tests - QNTM-3928 * Comments * Moving the test to NodeViewCustomizationTests.cs * Deleting changes to SerializationTests.cs * Create SerializationTests.cs * Update SerializationTests.cs * moving the test to UtilityTests.ca * Heterogeneous list update gives infinite loop DYN-1198 * Moving the test dyn file * Revert "Moving the test dyn file" This reverts commit d91009e. * Revert "Heterogeneous list update gives infinite loop" This reverts commit e8d7b8a. * making Surface.join node obsolete * Revert "making Surface.join node obsolete" This reverts commit 1458b46. * Obsoleting Surface,Join node. Use Polysurface.ByJoinedSurfaces node instead. * Renaming test file. * Updating file name (cherry picked from commit 219baa8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes the bug when using a heterogeneous list in computing some results. It runs into an infinite loop and eventually crashes the Dynamo.
There is a redundant 'for' loop on line: 217 in replicator.cs. This will recursively add unnecessary(duplicate) values to the ReducedParams list in there, which can be avoided.
I did some manual testing for other workflows which involved cartesian and zip replication.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap @mjkkirschner @QilongTang
FYIs
@alfarok @ColinDayOrg