Add marshaling between Dynamo and Python dictionaries #9296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
reviewed
Dec 7, 2018
| dict.Cast<dynamic>().ToDictionary(x => Marshal(x.Key), x => Marshal(x.Value))); | ||
| { | ||
| // Dictionary<TKey, TValue> and IronPython.Runtime.PythonDictionary both implement IDictionary | ||
| return dict.Keys.Cast<object>().ToDictionary(key => Marshal(key), key => Marshal(dict[key])); |
There was a problem hiding this comment.
does this work nicely for nested dictionaries?
|
@aparajit-pratap looks good |
|
@mjkkirschner seems to work for lists and nested dictionaries. |
|
@aparajit-pratap Awesome LGTM! Let me know if you need any sample graphs for testing, these might be useful. |
aparajit-pratap
commented
Dec 10, 2018
| if (val.GetType().IsValueType) | ||
| { | ||
| Assert.AreEqual(val, thisData.ValueAtKey(strKey)); | ||
| } |
There was a problem hiding this comment.
Added support to compare Dictionaries directly to test API: AssertValue
|
LGTM |
7 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add Dynamo Dictionary <-> Python Dictionary marshaling support.
JIRA: https://jira.autodesk.com/browse/QNTM-2990
Declarations
Check these if you believe they are true
*.resxfilesI've yet to add tests and run self-service - WIP
Reviewers
@alfarok
@mjkkirschner