Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Show/Hide geometry preview upstream #9294

Merged
merged 3 commits into from
Dec 7, 2018
Merged

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 6, 2018

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

QNTM-4110
[GIT][Regression] Remove preview upstream from the context menu. Also referred as #8795

Removed menu items from context menu and resource string.

Before:
image

After:
image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@alfarok

FYIs

@Racel

@QilongTang QilongTang added the WIP label Dec 6, 2018
@QilongTang QilongTang removed the WIP label Dec 6, 2018
@@ -1619,10 +1607,10 @@ Next assemblies were loaded several times:
<value>Package Path Added</value>
</data>
<data name="PackagePathAutoAddNotificationShortDescription" xml:space="preserve">
<value>A library (*.dll, *.ds) was recently imported into Dynamo. Its path was automatically added to "Settings > Manage Node and Package Paths..."</value>
<value>A library (*.dll, *.ds) was recently imported into Dynamo. Its path was automatically added to "Settings &gt; Manage Node and Package Paths..."</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are probably going to see this happening more in VS2017 now, converting special characters to syntax automatically. I don't think there are any repercussions opening it back up in VS2015.

@alfarok
Copy link
Contributor

alfarok commented Dec 7, 2018

@QilongTang LGTM

@alfarok alfarok added the LGTM Looks good to me label Dec 7, 2018
@QilongTang
Copy link
Contributor Author

@alfarok @Racel Self CI also passed, merging

@QilongTang QilongTang merged commit d7eb46e into master Dec 7, 2018
@QilongTang QilongTang deleted the HidePreviewUpstream branch December 7, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants