Crash creating automatic backup of Custom Node with special Characters

[reddyashish]

Purpose

This PR is to address the crash issues that were occurring due to special or non-printable characters in the Custom Node name.
https://jira.autodesk.com/browse/QNTM-3928.

Declarations

Check these if you believe they are true

• The code base is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @QilongTang @Racel @alfarok

FYIs

@ColinDayOrg

Error window for no category:

Error window for invalid file name:

[QilongTang]

Looks Good to me with one comment. UI interaction makes sense? @Racel

[Racel]

@reddyashish UI looks good. Please add tests.

[reddyashish]

Added the tests.

[QilongTang]

@reddyashish Can you do one favor for me and check if there is any file just for testing utilities? Because the place you put the test since does not seem to be the best, the tests there all tests serialization function which I think the test you end up using does not involve serialization

[QilongTang]

@reddyashish Only that last comment, otherwise, LGTM

[reddyashish]

@QilongTang I have moved the test to the NodeViewCustomizationTests.cs file. There is a UtilityTests.cs test suite as well but this looked more appropriate to me, as this had tests checking other functions of PathHelper class. Let me know if you think otherwise.

[QilongTang]

@reddyashish NodeViewCustomization does not seem proper either, can you move it to Dynamo\test\DynamoCoreTests\UtilityTests.cs? The nodeViewCustomization is for testing a customized NodeModel nodes with radio buttons, drops a 3rd party developer customize.

[QilongTang]

@reddyashish LGTM, once the PR checks passed, feel free to merge. Good work!

[reddyashish]

Yes. I will check that and merge it.