More fixes for keepListStructure #9275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename converter (spelling error) rename private fields for consistencey add tests for color and text
|
LGTM |
alfarok
reviewed
Nov 29, 2018
| @@ -109,7 +109,7 @@ | |||
| </Rectangle.Margin> | |||
| </Rectangle> | |||
| <Rectangle Name="highlightOverlay" | |||
| Fill="{Binding Path=ShouldKeepListStructure, Converter={StaticResource KeepListStructureHighlighColorConverter}}" | |||
| Fill="{Binding Path=ShouldKeepListStructure, Converter={StaticResource KeepListStructureHighlightColorConverter}}" | |||
There was a problem hiding this comment.
@mjkkirschner Is the Binding Path still ShouldKeepListStructure?
There was a problem hiding this comment.
yes, as this is on the portViewModel and not the model
|
@smangarole merged for testing. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/QNTM-4759
I missed some other behaviors which were broken in 2.0 release. I've fixed two of them and added a test.
KeepListStructureneeds to raise a change notification with the same string or the UI bindings will not fire.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@alfarok
@ColinDayOrg
FYIs
@smangarole