Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Image.Pixels to read full range of image. #9181

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Update Image.Pixels to read full range of image. #9181

merged 1 commit into from
Nov 19, 2018

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Oct 15, 2018 •
edited
Loading

Purpose

DynamoDS/DynamoRevit#2212

Declarations

Have not run the tests yet, only took a quick look.

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@alfarok

@mjkkirschner mjkkirschner changed the title Update FileSystem.cs Update Image.Pixels to read full range of image. Oct 15, 2018
@mjkkirschner mjkkirschner added bug PTAL Please Take A Look 👀 labels Oct 16, 2018
@alfarok
Copy link
Contributor

alfarok commented Nov 19, 2018

Just checked out the original issue, LGTM 👍

@alfarok alfarok added LGTM Looks good to me and removed PTAL Please Take A Look 👀 labels Nov 19, 2018
@QilongTang QilongTang merged commit 919765c into master Nov 19, 2018
@QilongTang
Copy link
Contributor

QilongTang commented Nov 19, 2018 •
edited
Loading

@mjkkirschner Mind cherry-picking to RC2.0.2?

@QilongTang QilongTang deleted the imagePixelsFullRange branch November 19, 2018 18:27
@mjkkirschner
Copy link
Member Author

sure

@QilongTang QilongTang added the 2.x Issues related to 2.x versions of Dynamo. label Nov 19, 2018
@QilongTang
Copy link
Contributor

QilongTang commented Nov 19, 2018 •
edited
Loading

@mjkkirschner Targetting Dynamo 2.1 forward, Please make a testing task in Dynamo 2.1 Epic.

@mjkkirschner
Copy link
Member Author

https://jira.autodesk.com/browse/QNTM-5895 @smangarole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.x Issues related to 2.x versions of Dynamo. bug LGTM Looks good to me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjkkirschner @alfarok @QilongTang