Fix Dictionary Preview in Code block node

[aparajit-pratap]

Purpose

The following node preview for a Dictionary in a CBN containing multple output ports does not expand currently. This is the screenshot after the fix:

This is because preferredDictionaryOrdering was a list of empty strings (3 in this case, one for each output port) and even though it should have been ignored it passed the check in DefaultWatchHandler::ProcessThing. This fix it to prevent the list from containing empty strings. Note that preferredDictionaryOrdering must only be populated for multi output nodes that have a MultiReturnAttribute.

Declarations

Check these if you believe they are true

• The code base is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner

FYIs

@jnealb

[mjkkirschner]

@aparajit-pratap just curious where did the extra entries come from? Does anything need to be updated similarly to this on the TS side?

[jnealb]

@aparajit-pratap @mjkkirschner Is there a JIRA task for this?

[aparajit-pratap]

@jnealb https://jira.autodesk.com/browse/QNTM-4916

[jnealb]

@aparajit-pratap Thanks.

[aparajit-pratap]

@mjkkirschner not sure what you mean by extra entries? Nothing needs to be updated on the TS side as this is more of a UI (preview) change in Dynamo.

[mjkkirschner]

@aparajit-pratap misunderstood, so previously the dictionary was not displayed for multi return functions called in code blocks if one of the outputs was an empty string?

[aparajit-pratap]

@mjkkirschner previously the dictionary could not be expanded in the preview if it was the output of a multi-output port code block node. Please don't confuse yourself with the contents of this Dictionary in the above example.

[aparajit-pratap]

@mjkkirschner good to go?

[mjkkirschner]

@aparajit-pratap LGTM