QNTM-4876: Fix List.MaximumItem for mixed types #9012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1399,7 +1399,7 @@ private static IList IncreaseDepth(IList list, int amt) | |||
| /// </summary> | |||
| private static object DoubleConverter(object obj) | |||
| { | |||
| if (obj is int) | |||
| if (obj is int || obj is long) | |||
There was a problem hiding this comment.
is max item the only place where the double converter is used?
There was a problem hiding this comment.
Doing a quick search in the code there are only two places in List.cs where DoubleConverter appears (other than the main class definition); MinimumItem and MaximumItem
There was a problem hiding this comment.
Yes. BTW this change is necessary after the switch from Int32 to Int64 types in DesignScript.
There was a problem hiding this comment.
yep yep, just curious if we should be looking for other regressions like this throughout the code base.
There was a problem hiding this comment.
@mjkkirschner @aparajit-pratap Take a look at QNTM-3423 and all linked issues.
|
LGTM - thanks @aparajit-pratap |
alfarok
pushed a commit
to alfarok/Dynamo
that referenced
this pull request
Nov 8, 2018
* fix List.MaximumItem for mixed types * add DYN graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes Github issue: #9009
JIRA: QNTM-4876
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@jnealb