Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QNTM-4488: Fix AST creation for partial multi-outport custom nodes #8928

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jun 13, 2018

Purpose

Fix for incorrect warning displayed with partial multi-output custom node when compiled to Dictionary.
image

Previously the compiled AST generated for such a node was:

varx["out1"] = varx_out1;
varx["out2"] = varx_out2;
varx["out3"] = varx_out3;

This should be compiled to:

varx = Dictionary.ByKeysValues(["out1", "out2", "out3"], [varx_out1, varx_out2, varx_out3]);

image

JIRA: https://jira.autodesk.com/browse/QNTM-4488

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner

FYIs

@kronz @jnealb

@aparajit-pratap aparajit-pratap changed the title Fix AST creation for partial multi-outport custom nodes QNTM-4488: Fix AST creation for partial multi-outport custom nodes Jun 13, 2018
@aparajit-pratap aparajit-pratap added the PTAL Please Take A Look 👀 label Jun 13, 2018
@mjkkirschner
Copy link
Member

@aparajit-pratap nice! will this magically fix this as well (I am guessing no 😉 )
#8912

@jnealb
Copy link
Collaborator

jnealb commented Jun 14, 2018

@aparajit-pratap @mjkkirschner @smangarole Should the title etc of QNTM-4488 be updated?

@aparajit-pratap
Copy link
Contributor Author

@jnealb I've updated the JIRA title.

@aparajit-pratap aparajit-pratap merged commit 41e2503 into DynamoDS:master Jun 15, 2018
@aparajit-pratap aparajit-pratap deleted the partialMultiOutput branch June 15, 2018 20:03
alfarok pushed a commit to alfarok/Dynamo that referenced this pull request Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PTAL Please Take A Look 👀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants