Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update librarie.min.js & decode search text #8776

Merged
merged 1 commit into from
Apr 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/LibraryViewExtension/Handlers/SearchResultDataProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ public override Stream GetResource(IRequest request, out string extension)
var pathAndQuery = uri.PathAndQuery;
var index = url.IndexOf(serviceIdentifier);
var text = url.Substring(index + serviceIdentifier.Length + 1);
// unescape query before searching
text = Uri.UnescapeDataString(text);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, this accepts all special chars?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so, here we unescape the encoded URI sent from Librarie.js before searching


var elements = model.Search(text);

Expand Down
2 changes: 1 addition & 1 deletion src/LibraryViewExtension/web/library/librarie.min.js

Large diffs are not rendered by default.