SearchTextBox centered #2071
Closed
SearchTextBox centered #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SearchTextBoxGrid_MouseEnter" and "SearchTextBoxGrid_MouseLeave" was changed due to needs of moving icon and text block. Now when mouse moves on SearchTextBoxGrid StackPanel moves at the left side.
…so alignment now depends on Converters class. There is c# code only in Conventers class and there is only one method in SearchView - SearchTextBox_MouseDown.
…, I have tried to use Focus of TextBox as Binding element, but there is one problem: if we have some text in textbox and than lose focus, our icon appears at the center. That's why using focus for binding is wrong solution. What I propose is to create new property in ViewModel. I called it CanAlingmentToLeft, that would depend not only on Focus, but also on value of textbox. Hope that you will accept this solution.
… white-space was deleted. It's ready for merge.
|
Closing this with Vladimir's request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Benglin, this pull request is result of #1954 . Before creating pull request we've merged with DynamoDS:Sitrus. In this commit all changes of task Centering SearchTextBox.
Please, review.