[DYN-7943] Custom node cannot be added to its own workspace.

[reddyashish]

Purpose

https://jira.autodesk.com/browse/DYN-7943

Users were experiencing a Dynamo freeze when they try to add a custom node in its own workspace. This will cause an infinite loop and shouldn't be allowed as it is not a ideal use case.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

[DYN-7943] Custom node cannot be added to its own workspace.

Reviewers

@QilongTang @zeusongit

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7943

[mjkkirschner]

@reddyashish - customnodes actually can be safely added to their own workspace if a user utilizes the scopeif node and properly implements the recursive base case... now, does anyone do that, I have no idea, it's really hard to get right - but perhaps existing packages should be evaluated before making this breaking change.

[QilongTang]

@reddyashish - customnodes actually can be safely added to their own workspace if a user utilizes the scopeif node and properly implements the recursive base case... now, does anyone do that, I have no idea, it's really hard to get right - but perhaps existing packages should be evaluated before making this breaking change.

Then maybe we change the message to, the custom node cant be safely placed into the current custom node workspace without scopeif node? It might be pretty easy to detect if there is any

[reddyashish]

Thank you both. I have updated the message to let users know about using the scopeif node.

I will check if this is breaking any existing packages.

[mjkkirschner]

I think @QilongTang was suggesting that in this check you iterate all the other nodes and make sure that one of them is scopeif OR you defer this check until they try to save the .dyf.

[mjkkirschner]

if you wanted to get really fancy you could try to determine if they have the scope if hooked up correctly or at least in a topology where it has even a remote chance of working...

[reddyashish]

Got it, looking into it.