Stabilize tests pt2 #15779
Merged
Stabilize tests pt2 #15779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: success. 11 passed, 0 failed. |
| System.Console.WriteLine($"PID {Process.GetCurrentProcess().Id} Start test: {TestContext.CurrentContext.Test.Name}"); | ||
| TestUtilities.WebView2Tag = TestContext.CurrentContext.Test.Name; | ||
|
|
||
| SynchronizationContext.SetSynchronizationContext(new DispatcherSynchronizationContext()); |
There was a problem hiding this comment.
Is this because the tests don't run in the UI thread by default?
There was a problem hiding this comment.
This code was simply moved to a new utility class, but the reasons for it (when it was added way back) was that tests were running on non UI threads
Comment on lines
+88
to
+93
| System.Console.WriteLine($"PID {id} Finished test: {name} with DispatcherOpsCounter = {DispatcherOpsCounter}"); | ||
| System.Console.WriteLine($"PID {id} Finished test: {name} with WorkingSet = {currentProc.WorkingSet64}"); | ||
| System.Console.WriteLine($"PID {id} Finished test: {name} with PrivateBytes = {currentProc.PrivateMemorySize64}"); | ||
| System.Console.Write($"PID {id} Finished test: {name} with GC Memory Info: "); | ||
| PrettyPrint(GC.GetGCMemoryInfo()); | ||
| } |
There was a problem hiding this comment.
Are these metrics expected to be nearly the same as before the tests started?
There was a problem hiding this comment.
In a perfect world, with no memory leaks, yes
aparajit-pratap
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
More test fixes:
Removed "SplashScreen close button" tests (why? because the close button was removed from the UI)
Moved Webview2 app data location in per component folders (inside the test subfolder so that it gets cleaned up after each CICD job automatically)
Moved Serialization test data to a per process folder (so that we do not have cross contamination between parallel tests)
Switched to GUIDs in the serialization tests so that the filtering system does not get confused (test methods sometimes had the same name as dyn files)
Moved some diagnostic logging and dispatcher logic to a new utility class "TestDiagnostics" so that other tests can use them easily.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of