DYN-7480 Update Resources Dynamo Core Wpf master_cl #15777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the DynamoCoreWpf.resources.dll was not generated for each language folder so I had to add the resources directly in that project.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7480
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
I've found a way to do the same without adding the resx files using VS2022, PR coming soon...... |
RobertGlobant20
deleted the
DYN-7480-UpdateResources-DynamoCoreWpf-master_cl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The DynamoCoreWpf.resources.dll was missing in language folders
I noticed that when compiling the Dynamo solution for most of the projects which contain resources in several languages (like Resources.es-ES.resx ) the ...resources.dll was generated correctly but the DynamoCoreWpf.resources.dll was missing (seems that even when the .resx files are located in
\src\DynamoCoreWpf\Propertiesthe resources are not loaded in VS2022).Then I modified the DynamoCoreWpf.csproj adding the resources directly, in that way the DynamoCoreWpf.resources.dll was generated sucessfully in each language folder.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
The DynamoCoreWpf.resources.dll was missing in language folders
Reviewers
@QilongTang @ZbynekHanak-RWS
FYIs