Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-8082 Do not assume array index #15772

Merged
merged 2 commits into from
Jan 27, 2025
Merged

DYN-8082 Do not assume array index #15772

merged 2 commits into from
Jan 27, 2025

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 22, 2025

Purpose

Crash prevention per https://jira.autodesk.com/browse/DYN-8082, since the CER report does not come with the crash line number, I scanned through the function and think only the array index getter would cause this. e.g. when a string ending with = would cause crash

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Crash prevention per DYN-8082 to prevent crash from happening

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added the WIP label Jan 22, 2025
@QilongTang QilongTang added this to the 3.5 milestone Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang changed the title [WIP] Do not assume index DYN-8082 Do not assume array index Jan 23, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8082

@QilongTang QilongTang marked this pull request as ready for review January 23, 2025 21:45
@QilongTang QilongTang removed the WIP label Jan 23, 2025
@QilongTang QilongTang merged commit 2f4aae1 into master Jan 27, 2025
27 of 30 checks passed
@QilongTang QilongTang deleted the GetCustomDocument branch January 27, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants