DYN-9999 : fix string type regex #15770
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9999
zeusongit
approved these changes
Jan 21, 2025
UI Smoke TestsTest: success. 11 passed, 0 failed. |
twastvedt
reviewed
Jan 22, 2025
src/NodeServices/PythonServices.cs
Outdated
| @@ -381,7 +381,7 @@ internal abstract class PythonCodeCompletionProviderCommon : IExternalCodeComple | |||
| internal static readonly Regex MATCH_FROM_IMPORT_STATEMENTS = new Regex(@"from\s+?([\w.]+)\s+?import\s+?([\w, *]+)", RegexOptions.Compiled | RegexOptions.Multiline); | |||
| internal static readonly Regex MATCH_VARIABLE_ASSIGNMENTS = new Regex(@"^[ \t]*?(\w+(\s*?,\s*?\w+)*)\s*?=\s*(.+)", RegexOptions.Compiled | RegexOptions.Multiline); | |||
|
|
|||
| internal static readonly Regex STRING_VARIABLE = new Regex("[\"']([^\"']*)[\"']", RegexOptions.Compiled); | |||
| internal static readonly Regex STRING_VARIABLE = new Regex("^[\"']([^\"']*)[\"']$", RegexOptions.Compiled); | |||
| internal static readonly Regex DOUBLE_VARIABLE = new Regex("^-?\\d+\\.\\d+", RegexOptions.Compiled); | |||
| internal static readonly Regex INT_VARIABLE = new Regex("^-?\\d+", RegexOptions.Compiled); | |||
| internal static readonly Regex LIST_VARIABLE = new Regex("\\[.*\\]", RegexOptions.Compiled); | |||
There was a problem hiding this comment.
Should these other variable regexs also have start and end markers?
There was a problem hiding this comment.
Yeah, I guess so, trying to think if there is any reason to be more loose but I can't find any.
twastvedt
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the autocomplete in the python editor.
We prepare autocomplete based on the variable type and sometimes we do not assign the correct type and the autocomplete is erroneous.
For example aa = HellowWorld("aaa") will be processed as aa being of type string and the autocomplete will be related to string type.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
FYIs