DYN-6897 Dynamo Button Disabled Revit #15722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening Dynamo in Revit2025 and closing the SplashScreen using the Windows TaskBar the Dynamo button is disabled (there is no way to re-enable it) so you need to close Revit to be able to see the Dynamo button enabled again. So in this fix I'm handling the case of re-enable the Dynamo button in Revit when the SplashScreen is closed using the Windows TaskBar (CloseMode.ByOther).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6897
|
This is a GIF showing the expected behavior when closing SplashScreen using Windows Taskbar (the Dynamo button is re-enabled when changing Tab, before my fix even changing Tab was not re-enabling the button). |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
RobertGlobant20
changed the title
QilongTang
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When opening Dynamo in Revit2025 and closing the SplashScreen using the Windows TaskBar the Dynamo button is disabled (there is no way to re-enable it) so you need to close Revit to be able to see the Dynamo button enabled again. So in this fix I'm handling the case of re-enable the Dynamo button in Revit when the SplashScreen is closed using the Windows TaskBar (CloseMode.ByOther).
TODO - This is just covering the Scenario 2 described in the Jira task DYN-6897 for the Scenario 1 I'm still checking the problem but in general until now I found that when closing the DynamoView (after was opened by pressing Start Dynamo in SplashScreen) we are generating the event WM_CLOSE (that's why the Dynamo button is re-enabled immediately) but when closing the SplashScreen using the close button or using the Windows Taskbar the WM_CLOSE event is not generated so the Dynamo button is not enabled immediately in Revit (just when the Revit workspace lose the Focus by clicking in a different part).
This was tested using Revit 2026 (Preview Release 20261111) using the DynamoRevit master branch and Dynamo RC3.4.0 branch.
In DynamoRevit I had to do a one line change for enabling the SplashScreen.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Scenario 2 when closing the SplashScreen using the Windows Taskbar and the Dynamo button in Revit is still disabled.
Reviewers
@QilongTang
FYIs