-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7919: Fix stray helpdoc filenames in infobubbles, remove dangling reference to inexistent helpdocs. #15688
Conversation
… reference to inexistent helpdocs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7919
UI Smoke TestsTest: success. 11 passed, 0 failed. |
@chubakueno Would you test after sanitizing the warning message, if clicking on |
Sure. Some warnings will no longer have the Duplicate warning after removal of the dangling |
Added tests to verify links are properly sanitized and extended the sanitizer to be more lenient (it will now accept everything until a space, newline, or end of string). |
@chubakueno Thank you, we will have a follow up task to add back the content missed |
Purpose
#14514 Introduced a bug in which the linked helpdoc file appears concatenated at the end of the message info bubbles (See DereferencingNonPointer.html in the PR screenshots). This PR fixes that issue by properly sanitizing the message content and it also removes dangling references to a testing.html helpdoc that never existed.
Message with bug:
Message without bug in case of several warnings:
Message without bug in case of a single warning:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Fix stray helpdoc filename at the end of infobubble messages, remove dangling reference to inexistent helpdocs.
Reviewers
@QilongTang
@RobertGlobant20
FYIs
@avidit