Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM - DYN-7756 Update Libg With improved MeshToolkit Warning #15654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Nov 14, 2024

Purpose

Update Dynamo Core with latest Libg Nuget. Change is an updated nfo message for Mesh Node constructors. DYN-7756.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Clear info message for Mesh Node constructors.

Reviewers

@twastvedt @QilongTang

FYIs

@saintentropy saintentropy added this to the 3.5 milestone Nov 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7756

@saintentropy
Copy link
Contributor Author

Hey @QilongTang and @twastvedt I marked this as 3.5. I noticed that there were a few other commits on the LibG branches that were from @pinzart that were after the version we have been testing. Those changes seems unrelated but I wanted @pinzart to weigh in if this would require any additional testings.

@saintentropy
Copy link
Contributor Author

Also if this can't be localized in time the first message is also fine. This is a Nice to have.

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@saintentropy
Copy link
Contributor Author

Hey @pinzart it does look that there is an issue with the linux changes (see build failure)

@saintentropy saintentropy added the DNM Do not merge. For PRs. label Nov 18, 2024
@saintentropy saintentropy changed the title DYN-7756 Update Libg With improved MeshToolkit Warning DNM - DYN-7756 Update Libg With improved MeshToolkit Warning Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM Do not merge. For PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant