Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-7427 Add missing node help docs for three nodes #15634

Merged
merged 2 commits into from
Nov 12, 2024
Merged

DYN-7427 Add missing node help docs for three nodes #15634

merged 2 commits into from
Nov 12, 2024

Conversation

QilongTang
Copy link
Contributor

Purpose

Add missing node help docs for couple nodes:

  • Color Palette
image
  • Rectangle.ByWidthLength
image
  • Utilities.ConvertByUnits
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Add missing node help docs for couple nodes.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.4 milestone Nov 12, 2024
@QilongTang QilongTang changed the title Add missing node help docs for color palette node DYN-7427 Add missing node help docs for color palette node Nov 12, 2024
github-actions[bot]
github-actions bot reviewed Nov 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7427

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang merged commit 8cc5818 into master Nov 12, 2024
24 checks passed
@QilongTang QilongTang deleted the AddMissingNodeHelpDocs branch November 12, 2024 13:59
@QilongTang QilongTang changed the title DYN-7427 Add missing node help docs for color palette node DYN-7427 Add missing node help docs for three nodes Nov 12, 2024
QilongTang added a commit that referenced this pull request Nov 12, 2024
@QilongTang
DYN-7427 Add missing node help docs for color palette node (#15634)
9ad38ee
@QilongTang QilongTang mentioned this pull request Nov 12, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@avidit avidit avidit approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

@reddyashish reddyashish Awaiting requested review from reddyashish

@RobertGlobant20 RobertGlobant20 Awaiting requested review from RobertGlobant20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @avidit