Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7736 Update Splash Screen #15616

Merged
merged 4 commits into from
Nov 8, 2024
Merged

DYN-7736 Update Splash Screen #15616

merged 4 commits into from
Nov 8, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Nov 7, 2024

Purpose

Update Splash Screen for GL 25 with reduced image size for the npm package. Also update the image used in Dynamo repo.

After:
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Update Splash Screen for GL 25 with reduced image size

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

github-actions bot commented Nov 7, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor Author

QilongTang commented Nov 7, 2024

@zeusongit looks like the public action build passed but build under VPN could not grab the latest npm package, have you seen this before?

This looks like a timing issue for ADSK to map public npm registry, now has been resolved

@QilongTang QilongTang added this to the 3.4 milestone Nov 7, 2024
@QilongTang QilongTang changed the title Update Splash Screen DYN-7736 Update Splash Screen Nov 7, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7736

@QilongTang QilongTang requested a review from zeusongit November 7, 2024 16:02
@zeusongit
Copy link
Contributor

Build failed as v26 was not available yet, Rebuild started here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16758/

@QilongTang
Copy link
Contributor Author

QilongTang commented Nov 8, 2024

@QilongTang QilongTang merged commit 7b33c30 into master Nov 8, 2024
22 of 24 checks passed
@QilongTang QilongTang deleted the UpdateSplashScreen branch November 8, 2024 07:14
QilongTang added a commit that referenced this pull request Nov 8, 2024
QilongTang added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants