-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7720. Add Help file documentation for Mesh Nodes from Meshtoolkit #15588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7720
UI Smoke TestsTest: success. 11 passed, 0 failed. |
My only concern is about all these geometry nodes' name lengths. I think sometime ago, @sm6srw had to convert long named files to be in hashed value. I forgot if C3D team or Revit team documented a limitation somewhere but I would encourage us using hashed value when we can. |
@QilongTang not sure what the limit is... Currently the longest Mesh file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@QilongTang I can't find the number yet that we convert files to hashed values. Since we are not longer then others I will merge and add this for follow up |
…DynamoDS#15588) (cherry picked from commit 5094d85)
Purpose
Documentation files are included for the new Mesh Nodes.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Documentation files are included for the new Mesh Nodes.
Reviewers
@LongNguyenP
FYIs
@Amoursol