Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6140: Fix ADP logging hang #15560

Merged
merged 1 commit into from
Oct 18, 2024
Merged

DYN-6140: Fix ADP logging hang #15560

merged 1 commit into from
Oct 18, 2024

Conversation

twastvedt
Copy link
Contributor

@twastvedt twastvedt commented Oct 18, 2024 •
edited
Loading

Purpose

Cherry pick #13685 to 2.16

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix a bug with ADP that caused a long delay in startup.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@BogdanZavu @twastvedt
AGD-2857 : cache adp analytics optin (#13678) (#13685)
e1ec900 
* cache adp analytics optin

* add comment

Co-authored-by: Bogdan Zavu <[email protected]>

Co-authored-by: Bogdan Zavu <[email protected]>
(cherry picked from commit 806231e)

# Conflicts:
#	src/DynamoCore/Configuration/PreferenceSettings.cs
@twastvedt
Copy link
Contributor Author

Successful build here: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-Dynamo/job/DynamoBuildscripts/job/RC2.16.x_master/48/

@twastvedt twastvedt merged commit a151dd8 into RC2.16.4_master Oct 18, 2024
14 of 16 checks passed
@twastvedt twastvedt deleted the DYN-6140-adp-logging-hang branch October 18, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BogdanZavu BogdanZavu BogdanZavu approved these changes

@QilongTang QilongTang QilongTang approved these changes

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twastvedt @QilongTang @BogdanZavu