Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-7436] Dynamo crashes upon exporting results if the destination file is #15545

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

PR aims to address DYN-7436.

When a user tries to export a .csv from the Graph Node Manager, the code now checks if the file is locked by another application. If the file is in use, a warning message is displayed, and the export is canceled. This behavior mirrors the implementation in TuneUp and PR #66.

The warning message and title have been added as resources to Dynamo.Wpf for localization support.

DYN-7436-Dynamo

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

When a user tries to export a .csv from the Graph Node Manager, the code now checks if the file is locked by another application. If the file is in use, a warning message is displayed, and the export is canceled.

Reviewers

@QilongTang
@reddyashish

FYIs

@dnenov
@Amoursol

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7436

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@reddyashish reddyashish merged commit aa9cb1b into DynamoDS:master Oct 14, 2024
25 checks passed
@QilongTang QilongTang added this to the 3.4 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants