Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7332: improvements after comments #15534

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

PR to address DYN-7332 and this Slack thread .

  • Pins are now automatically added to a group when created, if both the start and end nodes are in the same group.
  • Pins are selected when right-clicked, making it easier to interact with them.
  • The "Remove from Group" option is now updated correctly, so it becomes greyed out when the pin is no longer in a group, without needing to deselect and reselect the pin.

DYN-7332-After_comments

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Pins can now be added or removed from groups.

Reviewers

@QilongTang
@reddyashish

FYIs

@dnenov
@Amoursol

@github-actions github-actions bot changed the title improvements after comments DYN-7332: improvements after comments Oct 9, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7332

Copy link

github-actions bot commented Oct 9, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.4 milestone Oct 9, 2024
@QilongTang QilongTang merged commit 436d462 into DynamoDS:master Oct 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants