Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7337 TuneUp as default Built-in package #15526

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Oct 4, 2024

Purpose

TuneUp as built-in package for Dynamo.

The following action is TBD and may not be part of the repo:

  • What's the future of TuneUp automatic Built-in package integration? Nuget package or Dynamo package or continue this way. I am leaning not the Nuget package because that's polluting the fact TuneUp itself is a Dynamo package, but also would prefer not a hard copy.
  • User's ability to adjust Built-in package path order? Wouldn't we always want Built-In to be last so newer version of the package can be loaded first?

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Make TuneUp as built-in package for Dynamo.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.4 milestone Oct 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7337

@QilongTang
Copy link
Contributor Author

The build is failing because TuneUp is not versioned with Dynamo versions..

@avidit
Copy link
Contributor

avidit commented Oct 8, 2024

The build is failing because TuneUp is not versioned with Dynamo versions..

You and add TuneUp.dll here to ignore this from version check. Will TuneUp.dll eventually have same version as Dynamo?

@QilongTang
Copy link
Contributor Author

QilongTang commented Oct 8, 2024

The build is failing because TuneUp is not versioned with Dynamo versions..

You and add TuneUp.dll here to ignore this from version check. Will TuneUp.dll eventually have same version as Dynamo?

Thank you for the top. I would like to discuss with team about this. I feel TuneUp will stay in its own versions since we intend to update it separately.

@QilongTang QilongTang marked this pull request as ready for review October 8, 2024 13:25
Copy link

github-actions bot commented Oct 8, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor Author

Updated Unit test, this PR should be ready for review

@QilongTang QilongTang merged commit c4fa945 into master Oct 8, 2024
24 checks passed
@QilongTang QilongTang deleted the TuneUpAsBuiltInPackage branch October 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants