Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7442 Search Nodes with Special Characters #15513

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Fixing Search bug that is happening when searching nodes in which the name contain special characters.
When Searching nodes with special characters in the Name when Dynamo is in a different language than English was not getting the expected results, the problem was related to the Analyzer being used. In this fix I'm using the CustomAnalyzer providing the Dynamo language as a parameter, this will allow using the expected character set.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing Search bug that is happening when searching nodes in which the name contain special characters.

Reviewers

@QilongTang

FYIs

When Searching nodes with special characters in the Name when Dynamo is in a different language than English was not getting the expected results, the problem was related to the Analyzer being used.
In this fix I'm using the CustomAnalyzer providing the Dynamo language as a parameter, this will allow using the expected character set.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7442

@RobertGlobant20
Copy link
Contributor Author

GIF showing expected behavior in Spanish
vmPNu8tDrU

@RobertGlobant20
Copy link
Contributor Author

GIF showing expected behavior in German.
aMoWXmACA3

@QilongTang QilongTang modified the milestones: 2.16.4, 3.4 Oct 2, 2024
@QilongTang
Copy link
Contributor

@RobertGlobant20 There are two build errors from the build action, please address

Updating the public API due that a new parameter was added in the LuceneCustomAnalyzer constructor.
Copy link

github-actions bot commented Oct 2, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@RobertGlobant20
Copy link
Contributor Author

@RobertGlobant20 There are two build errors from the build action, please address

I've submitted a fix for updating the public API, commit: 2955a8f

@QilongTang
Copy link
Contributor

There are some regressions but seems unrelated, would you re-run https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16491/?

@RobertGlobant20
Copy link
Contributor Author

@QilongTang QilongTang merged commit f2b39ba into DynamoDS:master Oct 2, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants