-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7442 Search Nodes with Special Characters #15513
DYN-7442 Search Nodes with Special Characters #15513
Conversation
When Searching nodes with special characters in the Name when Dynamo is in a different language than English was not getting the expected results, the problem was related to the Analyzer being used. In this fix I'm using the CustomAnalyzer providing the Dynamo language as a parameter, this will allow using the expected character set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7442
@RobertGlobant20 There are two build errors from the build action, please address |
Updating the public API due that a new parameter was added in the LuceneCustomAnalyzer constructor.
UI Smoke TestsTest: success. 11 passed, 0 failed. |
I've submitted a fix for updating the public API, commit: 2955a8f |
There are some regressions but seems unrelated, would you re-run https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16491/? |
After re-running the job now is passing. |
Purpose
Fixing Search bug that is happening when searching nodes in which the name contain special characters.
When Searching nodes with special characters in the Name when Dynamo is in a different language than English was not getting the expected results, the problem was related to the Analyzer being used. In this fix I'm using the CustomAnalyzer providing the Dynamo language as a parameter, this will allow using the expected character set.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Fixing Search bug that is happening when searching nodes in which the name contain special characters.
Reviewers
@QilongTang
FYIs