Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6208 Update Dynamo Website Menu Item behavior #15469

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

QilongTang
Copy link
Contributor

Purpose

Clicking on Dynamo Website menu item now goes to dynamobim.org while the new Dynamo Repository menu item goes to dynamo repo (the legacy Dynamo Website menu item behavior).
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Clicking on Dynamo Website menu item now goes to dynamobim.org while the new Dynamo Repository menu item goes to dynamo repo (the legacy Dynamo Website menu item behavior).

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.4 milestone Sep 9, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6208

@QilongTang
Copy link
Contributor Author

hi @avidit How to update the Smoke test for menu items?

@avidit
Copy link
Contributor

avidit commented Sep 9, 2024

hi @avidit How to update the Smoke test for menu items?

I will update the test.

Copy link
Contributor

@avidit avidit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit 12eae52 into master Sep 9, 2024
26 of 27 checks passed
@QilongTang QilongTang deleted the FixDynamoWebsiteMenu branch September 9, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants