Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-7331] Update all bubble states with high-resolution icons #15454

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

Small PR aiming to address https://jira.autodesk.com/browse/DYN-7331 .
Replace the icons with a high-resolution image for all the warning/error/info bubble states. As instructed, icon are taken from https://www.figma.com/design/ BKLbiZk1No0Qg8tWdm87iX/Dynamo-UI-Icons?node-id=39-16&t=OhKIz2E8kZsTpiQ0- 1

Hope that's okay 🤞

DYN-3771_Fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Updated high-resolution icons for all the warning/error/info bubble states.

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

48px from Figma
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7331

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.3 milestone Aug 30, 2024
@QilongTang QilongTang merged commit 6b3c939 into DynamoDS:master Aug 30, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants