[DYN-7332] Add pins to groups #15452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ unit test
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7332
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
approved these changes
Aug 29, 2024
|
@ivaylo-matov This test ConnectorPinsGetsAddedToTheGroup is failing. Can you check that? |
`AddConnectorPinsToGroups` was failing because the original version on `Nodes` was excluding pins from selection, but adding pins related to nodes.
|
@reddyashish , this commit should fix the issue. All tests from AnnotationViewModelTests & AnnotationViewTests pass now. |
|
Self serve job did not complete. Running it again https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16390/ |
|
This one test is failing: Dynamo.Tests.SchedulerIntegrationTests.TestTaskQueuePreProcessing01. |
QilongTang
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PR aiming to address https://jira.autodesk.com/browse/DYN-7332 . Allows users to manually add connectorPins to groups.
Unit test included.
Hope that's okay 🤞
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Users can now manually add pin to group even if the related nodes are outside that group.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol