DYN-7236 New debug option to dump node help data #15447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7236
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
Something is up with Harmony scans, some builds are timing out, re-ran this one and it passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16379/ |
QilongTang
reviewed
Aug 28, 2024
| @@ -3498,6 +3498,90 @@ private static void LoadLibraryEvents_LoadLibraryFailure(string failureMessage, | |||
| Wpf.Utilities.MessageBoxService.Show(failureMessage, messageBoxTitle, MessageBoxButton.OK, MessageBoxImage.Exclamation); | |||
| } | |||
|
|
|||
| internal string GetMinimumQualifiedName(NodeModel nodeModel) | |||
There was a problem hiding this comment.
Maybe some comments to the functions? Understand that some of them are simply moved from the other class
QilongTang
reviewed
Aug 28, 2024
| } | ||
| private DirectoryInfo GetNodeHelpDocPath() | ||
| { | ||
| const string SHARED_DOCS_DIRECTORY_NAME = "NodeHelpSharedDocs"; |
There was a problem hiding this comment.
There should be the same const somewhere else, maybe worth moving to a const under DynamoConfiguration class?
QilongTang
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a new Debug Menu option to Dump Node Help Docs Data
The Node Help Data includes:
The logs are written to - C:\Users<User>\AppData\Roaming\Dynamo\Dynamo Core<Dynamo-Version>\Logs
Current stats:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of