DYN-7273 Search Issue Civil3D #15420
Conversation
When a user in Civil3D was searching for a node like "choose text style" no results were not found in the top ten nodes. This problem was happening due that when the SearchTerm contains empty space the algorithm parse the term in tokens so matches all the nodes which contain "choose", "text" and "style" in the node name and due that there is a restriction that the if the number of matching nodes > 20 then discard that case so is not showing results for that searchTerm. Also there was a missing condition that when the term has spaces we should try to match the name with spaces, this was the code added in this commit and this is why now we are getting results when searching for "choose text style".
Removed unused using
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7273
|
This is a GIF of the expected behavior in Revit 2025. |
|
This is a GIF of the expected behavior in Civil3D 2025 Update 2025.1. |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
I realized that with my fix searching for "set parameter" in Revit was moving the SetParameterByName node from the 1st position to the 5th position then for fixing that problem I've modified the code in a way that will be using the default weight for Wildcard Query (instead of using the once calculated by the CalculateFieldWeight() method), Also was reported that when searching for "file path" was not showing the File Path node in the list, it was happening due that the word "file" is a Category so the results were showing the nodes under the File Category that contain the word "path" in the Name. For fixing this problem I removed the MUST for the category so it will show also extra nodes in the results (including the File Path node).
|
GIF showing the results of the search criteria "file path","set parameter", "element set parameter", "setparameter" on Revit. |
|
GIF showing the result of searching for "choose text style" in Civil3D. |
Added a unit test that validates that the "File Path" node is found at the top 5 results when searching for the criteria "file path".
|
Looks good but cant really merge right now with the builds failing. The failure is not related to this code though. |
|
Hi @RobertGlobant20 Please update your fork/branch with #15428 |
| @@ -379,7 +379,6 @@ internal string CreateSearchQuery(string[] fields, string SearchTerm, bool IsPac | |||
| { | |||
| //Means that the first term is a category when we will be using the FullCategoryName for making a specific search based in the category | |||
| trimmedSearchTerm = matchingCategory?.FullCategoryName; | |||
| occurQuery = Occur.MUST; | |||
There was a problem hiding this comment.
Reason behind removing this?
There was a problem hiding this comment.
when searching for criteria like "file path" with MUST we were creating a query like this one (consider that the word 'file' is a Category):
SELECT .... FROM ..... WHERE CATEGORY = 'file' AND (NAME LIKE 'path' or NAME LIKE ''path*)
so it was returning the two nodes in which Category = 'Core.File' that match the criteria related with the Name (the Name should contain 'path'),
But the user is expecting the "file path" node - this one didn't match due that belongs to the Category = "Core.Input" so removing the MUST makes the query more flexible showing also the nodes that matches the Name = 'file path' OR the Category = "Core.File".
Please let me know if this is clear enough.
| @@ -409,6 +408,22 @@ internal string CreateSearchQuery(string[] fields, string SearchTerm, bool IsPac | |||
|
|
|||
| if (searchTerm.Contains(' ')) | |||
There was a problem hiding this comment.
Can we somehow combine this and the hasEmptySpaces flag, so that we do not have to check this twice, and probably avoid some confusion in the future?
There was a problem hiding this comment.
I will suggest to consider this refactoring for a different Jira task since I remember it generated other problems also the hasEmptySpaces is under a condition that you added probably we will need to think more about it.
|
@QilongTang any idea why the Dynamo.Tests.ExcelTests.ReadChangeFilename() test is failing, I was checking the test code and I don't see why it should be related. |
Purpose
When a user in Civil3D was searching for a node like "choose text style" no results were not found in the top ten nodes.
This problem was happening due that when the SearchTerm contains empty space the algorithm parse the term in tokens so matches all the nodes which contain "choose", "text" and "style" in the node name and due that there is a restriction that the if the number of matching nodes > 20 then discard that case so is not showing results for that searchTerm.
Also there was a missing condition that when the term has spaces we should try to match the name with spaces, this was the code added in this commit and this is why now we are getting results when searching for "choose text style".
I realized that with my fix searching for "set parameter" in Revit was moving the SetParameterByName node from the 1st position to the 5th position then for fixing that problem I've modified the code in a way that will be using the default weight for Wildcard Query (instead of using the once calculated by the CalculateFieldWeight() method),
Also was reported that when searching for "file path" was not showing the File Path node in the list, it was happening due that the word "file" is also a Category so the results were showing the nodes under the File Category that contain the word "path" in the Name. For fixing this problem I removed the MUST for the category so it will show also extra nodes in the results (including the File Path node).
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
When a user in Civil3D was searching for a node like "choose text style" no results were not found in the top ten nodes.
Reviewers
@QilongTang
FYIs
@reddyashish