Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6620 Add version size data to Package Details #15411

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

The PR will add package version size data to Package details table.

  • Size is extracted from package metadata received from Package Manager
  • Size already formatted in readable units
  • Using KiB, MiB notations as supported by AWS (Mutiple Byte Units)

Update Greg nuget version to 3.0.2.5756

Screenshot 2024-07-30 at 1 00 36 AM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Added size data to Package details view

Reviewers

@DynamoDS/dynamo

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang added this to the 3.3 milestone Jul 30, 2024
@zeusongit zeusongit changed the title Add version size data to Package Details DYN-6620 Add version size data to Package Details Jul 30, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6620

Copy link

github-actions bot commented Jul 30, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@zeusongit zeusongit merged commit e98e07f into DynamoDS:master Jul 30, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants