DYN-7218 Revit Crash FileTrust Popup #15405
Conversation
Under a specific case when the FileTrust Popup is visible and Dynamo is closed the Popup remains open then if the user clicks any button Revit crashes. For fixing this problem I've added a piece of code that will be closing the FileTrust Popup when Dynamo is closed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7218
|
This GIF is showing the steps when Revit is crashing |
|
This GIF shows that after my fix is not crashing. |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
| if(fileTrustWarningPopup != null && fileTrustWarningPopup.IsOpen) | ||
| { | ||
| fileTrustWarningPopup.IsOpen = false; | ||
| } |
There was a problem hiding this comment.
hi @RobertGlobant20 I understand the intention here, but again since the TrustWarningPopup being the only exception here (a specific close), I had to ask why it can't be closed like the other popups? We should have plenty other instances, e.g. incanvas search, notification center, guided tour?
There was a problem hiding this comment.
@QilongTang I noticed that this code is not needed due that there is already funcionality closing the Popup when Dynamo is closed.
But related to your question, the fileTrustWarningPopup is begin hidden/shown depending if Dynamo window is Active or not, if you are aware about any problem in NotificationCenter or GuidedTour popups please let me know so I can investigate more about it.
I noticed that there is no need to close directly the fileTrustWarningPopup due that there is already functionality that is doing that. So I just had to set the FileTrustViewModel.DynFileDirectoryName for the SaveAs functionality and the Popup will be closed automatically when closing Dynamo.
Purpose
Fixing Revit Crash when closing the FileTrust Popup
Under a specific case when the FileTrust Popup is visible and Dynamo is closed the Popup remains open then if the user clicks any button Revit crashes. For fixing this problem I've added a piece of code that will be closing the FileTrust Popup when Dynamo is closed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Revit Crash when closing the FileTrust Popup
Reviewers
@QilongTang
FYIs