-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-4617 : use biginteger from pythonnet directly #15387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Should there be a test on Dynamo side, or are the tests we have already in PythonNet enough?
Are you planning to use the https://github.com/DynamoDS/Dynamo/tree/pythonnet_3.1.0 branch to implement all pythonnet3 changes ? Then take out the cpython project into a separate dynamo package ? |
Just to give another heads up, some of the changes that I made to https://github.com/DynamoDS/Dynamo/tree/pythonnet_3.1.0 have not been properly validated/tested. |
I don't think so, what we have on python side should do it. |
I think so yes.
Not sure but that sounds plausible, we have a task to decide on this. |
We'll figure it out if something is not working but since you brought this up just to confirm : the changes related to pythonnet3.1 are your last 3 commits ? |
Correct |
Co-authored-by: Bogdan Zavu <[email protected]>
Purpose
No need to have our own decoder and encoder anymore for the BigInteger since pythonnet 3.1.0 has added support for this.
Operations with BigInteger works as before in a python script in Dynamo.
Declarations
Check these if you believe they are true
*.resx
files