Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6547: toggle depreciate revised #15383

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jul 11, 2024

Purpose

This is a follow up PR on #15365. @avidit reported that the previous implementation was not working as expected. After revising the code, I realized I was using an end point not meant for this purpose.

Changed the implementation to fetch deprecated data directly form the Cached Package List, which should report the correct information.

Also reverted the changes to the Get Maintainers name from the previous PR.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • previously relied on an end-point, which wasn't built for the purpose and was retrieving false information
  • now fetches the deprecated status directly from the cached package list, which should contain the correct information

Reviewers

@avidit
@zeusongit
@QilongTang

FYIs

@reddyashish

dnenov added 2 commits July 11, 2024 13:32
- previously relied on an end-point, which wasn't built for the purpose and was retrieving false information
- now fetches the deprecated status directly from the cached package list, which should contain the correct information
- revert change to the GetPackageMaintainers method using the GetMaintainers endpoint
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6547

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.3 milestone Jul 11, 2024
@QilongTang QilongTang merged commit aba9359 into DynamoDS:master Jul 11, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants