DYN-6569 Extended Characters Md2HTML Fix #15377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending extended characters to the Md2HTML tool (using stdin and stdout) was replacing the characters by other weird symbols then for fixing this problem I'm encoding the info to base64 when sending and decoding the info when getting the html (from Md2HTML).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6569
|
SweepAsSurface - Czech |
|
ImportExcel- Czech |
|
SweepAsSurface - 한국인 |
|
ImportExcel - 한국인 |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
reviewed
Jul 9, 2024
QilongTang
reviewed
Jul 9, 2024
QilongTang
reviewed
Jul 9, 2024
Moved methods DecodeHTMLContent and DecodeBase64 to the Md2HTML class (I had to convert the methods to be static). Added comments in the EncodeBase64 method. In the DecodeBase64 method the Catch section was updated
QilongTang
reviewed
Jul 9, 2024
QilongTang
reviewed
Jul 9, 2024
I've added a unit test that validates that the extended characters are processed correctly by the Md2Html.exe tool. Also I've modified some methods in the Md2Html.cs file to be static
When running the test it was trying to read the files from a specific language location but that location doesn't exist when running the job so I copied the md file to a different location and modified the test to use this new location.
After debugging more and inserting logs inside the Md2Html.exe tool I notice that at the beginning when chosing the UTF-8 Encoding we were sending some weird characters so instead of using == now I'm using .Equals(). So I deleted the previous code for encoding and decoding the content and set to create the process with UTF-8.
I've removed the code for encoding and decoding so this tests should be passing and also the test that I added. |
Removing unnecessary usings.
Fixing test for parsing the html content with regular expressions
QilongTang
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing problem when displaying extended characters in DocumentationBrowser
When sending extended characters to the Md2HTML tool (using stdin and stdout) was replacing the characters by other weird symbols then for fixing this problem I'm encoding the info to base64 when sending and decoding the info when getting the html (from Md2HTML).
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing problem when displaying extended characters in DocumentationBrowser
Reviewers
@QilongTang
FYIs
@mjkkirschner