Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-7190: As a Dynamo integrator, I would like to config videos on Learning tab #15370

Merged
merged 1 commit into from
Jul 10, 2024
Merged

DYN-7190: As a Dynamo integrator, I would like to config videos on Learning tab #15370

merged 1 commit into from
Jul 10, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jul 3, 2024 •
edited
Loading

Purpose

Addresses issue: https://jira.autodesk.com/browse/DYN-7190 As a Dynamo integrator, I want to customize Dynamo Home experience. Works with DynamoDS/DynamoHome#25.

Addresses

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • added videos to the app.config file as a json string
  • the video data can now be configured from the Dynamo project independently from the web app
  • added necessary helper structures to support the slightly more complex video data format we expect

Reviewers

@QilongTang

FYIs

@reddyashish

@dnenov
videos to config
f20312e 
- added videos to the app.config file as a json string
- the video data can now be configured from the Dynamo project independently from the web app
- added necessary helper structures to support the slightly more complex video data format we expect
@github-actions github-actions bot changed the title videos to config DYN-7190: videos to config Jul 3, 2024
github-actions[bot]
github-actions bot reviewed Jul 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7190

@dnenov dnenov mentioned this pull request Jul 3, 2024
Merged
@QilongTang QilongTang added this to the 3.3 milestone Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang changed the title DYN-7190: videos to config DYN-7190: As a Dynamo integrator, I would like to config videos on Learning tab Jul 3, 2024
@QilongTang
Copy link
Contributor

passed at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16264/

@QilongTang QilongTang merged commit c7d5ad4 into DynamoDS:master Jul 10, 2024
44 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@dnenov @QilongTang