Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7207 Update DefineData sample #15369

Merged
merged 1 commit into from
Jul 11, 2024
Merged

DYN-7207 Update DefineData sample #15369

merged 1 commit into from
Jul 11, 2024

Conversation

twastvedt
Copy link
Contributor

@twastvedt twastvedt commented Jul 2, 2024

Purpose

The DefineData node's sample file uses "Lock/unlock" terminology from an in-progress version of the node's UI. Update to the final "Auto-detect type" language.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Updated the DefineData node's sample file.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@twastvedt twastvedt requested a review from dnenov July 2, 2024 19:00
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7207

@twastvedt twastvedt requested a review from QilongTang July 2, 2024 19:01
Copy link

github-actions bot commented Jul 2, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link
Collaborator

@dnenov dnenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR 'translates' the outdated terminology 'Lock/Unlock' replacing it with the current 'Auto-detect' nomenclature. It all make sense to me!

@dnenov dnenov merged commit 9a5a078 into master Jul 11, 2024
28 of 30 checks passed
@dnenov dnenov deleted the DYN-7207-definedata-sample branch July 11, 2024 15:24
@QilongTang QilongTang added this to the 3.3 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants