DYN-6901 Pm - publish version preview fix #15360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- plotting out the publishing process with series of tests
- previously dynamo would add dyf and dll files regardless of the capitalization of the extesion. However - however, when copying the files this was not respected - now also copies the files awith upper capitalization
- fixed caps extension issue in preview and remove
- confirm that the original custom definition files will be deleted during the build process - fixed a few more extension capitalizations
- rework on the way the content structure is recreated (files and folders relationships) - additional test coverage to assert edge case scenarios
- rework of most of the logic behind retaining folder structure - fixing tests
- we cannot really allow to keep the existing pkg.json file because that will invalidate the form filling part of the process
…tructure-updates-rework
…ructure-updates-rework
- this was a mix-up of the old way of displaying custom nodes and the new ones only
…tructure-updates-rework-publishversion
…nfolderstructure-updates-rework-publishversion
dnenov
changed the title
9 tasks
…tructure-updates-rework-publishversion
reddyashish
approved these changes
Jul 11, 2024
|
hi @dnenov Please resolve the merge conflicts |
…tructure-updates-rework-publishversion
- we need to create pkg.json in all cases, according to current design
dnenov
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6901
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
approved these changes
Jul 22, 2024
|
All resolved on this side now @QilongTang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A small PR that fixes an edge-case where the Custom Definitions won't preview correctly under the
Publish Versionworkflow.Based on the #15314 series.
Before
After
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@zeusongit
@reddyashish
FYIs
@Amoursol