-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7162 Add back missing node help docs and fix cases were not working #15349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7162
UI Smoke TestsTest: success. 3 passed, 0 failed. |
Added, @QilongTang ! |
Awesome, thanks! |
… into MissingNodeHelpDyn
SelfServe job interrupted, restarted at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16229/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
![Math.Random2](./DSCore.Math.Random%28value1%2C%20value2%2C%20seed%29_img.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you tested this one and is showing the documentation correctly, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was using the VSCode md preview and it worked after the change
It was passing last night on https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16225/, the CI seems to be down today so merging for now and FYI @sm6srw |
Purpose
Per Slack conversation, team finished a round of internal checking on nodes missing help content. In this PR, I am adding back missing dyns that I could validate which were missing.
Also fixed image display for the following nodes:
Added copy step for excel sheets in help docs
It looks like the dyn file was missing from original PR: AGD-2199 - custom dropdown node #11958)Node with issue
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Add back missing node help docs so that customer could see in product help
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of