Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7155: Cherry pick - Update libg build that contains fully qualified namespaces for default args #15337

Merged

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jun 20, 2024

Purpose

Cherry pick: New libg build contains fully qualified namespaces for default args

https://jira.autodesk.com/browse/DYN-7155

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Geometry nodes now contain fully qualified namespaces for default args to avoid namespace conflicts

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@aparajit-pratap aparajit-pratap changed the title Cherry pick: New libg build contains fully qualified namespaces for default args DYN-7155: Cherry pick - New libg build contains fully qualified namespaces for default args Jun 20, 2024
@github-actions github-actions bot changed the title DYN-7155: Cherry pick - New libg build contains fully qualified namespaces for default args DYN-7155: Cherry pick: New libg build contains fully qualified namespaces for default args Jun 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7155

@github-actions github-actions bot changed the title DYN-7155: Cherry pick: New libg build contains fully qualified namespaces for default args DYN-7155: Cherry pick - New libg build contains fully qualified namespaces for default args Jun 20, 2024
@aparajit-pratap aparajit-pratap requested a review from sm6srw June 20, 2024 16:34
@aparajit-pratap aparajit-pratap changed the title DYN-7155: Cherry pick - New libg build contains fully qualified namespaces for default args DYN-7155: Cherry pick - Update libg build that contains fully qualified namespaces for default args Jun 20, 2024
@aparajit-pratap aparajit-pratap merged commit 298a7f3 into DynamoDS:RC3.2.1_master Jun 20, 2024
28 of 33 checks passed
@aparajit-pratap aparajit-pratap deleted the RC3.2.1_master branch June 20, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants