Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7156: initialize libview only once #15335

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

pinzart90
Copy link
Contributor

Purpose

https://jira.autodesk.com/browse/DYN-7156
LibraryView is initialized in the Revit context. This means that when you try to create a single node, multiple nodes are place inside the workspace.
This PR ensure that the node library view is initialzied only once

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix issue where multiple nodes are created when selecting a single node from the libray view.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions github-actions bot changed the title initialize libview only once DYN-7156: initialize libview only once Jun 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7156

@pinzart90
Copy link
Contributor Author

Looking into tests...

@QilongTang QilongTang added this to the 3.3 milestone Jun 20, 2024
@pinzart90 pinzart90 merged commit 83e3d0f into master Jul 1, 2024
25 of 26 checks passed
@pinzart90 pinzart90 deleted the libviiew_multi_initializations branch July 1, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants