DYN-7154: missing thumbnail sample files #15326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added the missing properties to the sample files by inheriting from the already existing StartPageListItem - refactored repetitive code - tests added - api updated
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7154
UI Smoke TestsTest: success. 2 passed, 0 failed. |
reddyashish
reviewed
Jun 18, 2024
reddyashish
approved these changes
Jun 18, 2024
|
@dnenov You are missing the change to update the dynamo home version in DynamoCoreWpf.csproj. |
yeah, you can refer to https://github.com/DynamoDS/Dynamo/pull/15316/files to define updated version |
reddyashish
approved these changes
Jun 18, 2024
|
Thanks @reddyashish @dnenov for the quick turn around |
QilongTang
approved these changes
Jun 18, 2024
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
Jun 20, 2024
(cherry picked from commit 99aa11d)
9 tasks
reddyashish
added a commit
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addressing this
jiraissue: https://jira.autodesk.com/browse/DYN-7154Missing thumbnails for sample files in DynamoCore 3.2 new home page. To be consumed with the HomePage app changes in this PR DynamoDS/DynamoHome#23Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
FYIs
@Amoursol